Repository navigation
fix(sdk): instant search merchants, push click attribution, profile dates (DEV-4732) - #236
Merged
Merged
Conversation
…locations again: without locations the server's merchant filter matches no product and the search comes back empty
…, like tracking.setSource, and no longer adds from and code to every request: /init took them for a new click of the mailing on every launch
…ot as Date.toString() and a Java array's toString()
… every request; a clicked push lives in the tracking source
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes from DEV-4732, checked against the backend code and the live API:
excluded_merchantsonly with non-emptylocationsagain. Without locations the server's merchant filter matches no product: 2568 results become 0. This reverts the 2.48.0 change.fromandcodeto every request for 48 h./inittook them for a new click of the mailing on every launch. The click now sets the tracking source, which goes assourcein/pushevents. Old-format popups targeted by mailing (usage) no longer see the push click on/init.ProfileParams: aDategoes asYYYY-MM-DDand arrays as JSON arrays, not asDate.toString()and[Ljava.lang.String;@….